Skip to content

Custom legend block for group #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

lionel-bijaoui
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Legend template can't be changed

  • What is the new behavior (if this is a feature change)?

Legend template can be changed with slot (named group-legend)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

    • Possibility to use scoped-slot to customize fully how legend is build
    • Expose group and groupLegend in slot prop

- Possibility to use scoped-slot to customise fully how legend is build
- Expose `group` and `groupLegend` in slot prop
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.92% when pulling b694fae on lionel-bijaoui:lb_custom_legend into 55b5d9f on vue-generators:v3.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.92% when pulling b694fae on lionel-bijaoui:lb_custom_legend into 55b5d9f on vue-generators:v3.

@lionel-bijaoui lionel-bijaoui merged commit 322fb57 into vue-generators:v3 Oct 19, 2018
@lionel-bijaoui lionel-bijaoui deleted the lb_custom_legend branch October 19, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants