small fix #47
Merged
small fix #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2016 15:30
…n both commands (test and ci) run at the same time
| @@ -17,7 +17,7 @@ | |||
| "e2e": "node test/e2e/runner.js", | |||
| "pretest": "npm run lint", | |||
| "test": "npm run unit", | |||
| "ci": "karma start test/unit/karma.conf.js --auto-watch --no-single-run --reporters=dots" | |||
| "ci": "karma start test/unit/karma.conf.js --auto-watch --no-single-run --reporters=dots --port=9877" | |||
There was a problem hiding this comment.
As I said in the commit, It allow to use both npm run test and npm run ci at the same time without warning. It is a very small stuff, but since I use them all the time, I want to avoid any interference even if very unlikely.
|
ok, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small stuff, should be quickly merge if you agree with the changes