added labelClasses support #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icebob
requested changes
Nov 10, 2017
…tor and not the field components
|
Not too familiar with your testing policies ... does the formGenerator test cover it? |
zoul0813
commented
Nov 11, 2017
src/formGenerator.vue
Outdated
| @@ -571,3 +569,11 @@ div.vue-form-generator(v-if='schema != null') | |||
|
|
|||
| } // fieldset | |||
| </style> | |||
| // .errors | |||
There was a problem hiding this comment.
oops ... how'd that get there?
not sure how that got there
zoul0813
added a commit
to zoul0813/vue-form-generator
that referenced
this pull request
Nov 15, 2017
vue-generators#339 appears to have been overwritten by vue-generators#342?
|
labelClasses field does not seem to be working for me as I am trying to add a fontawesome icon next to the field. Is there anyway to do so? Do you have any example? |
|
Please ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #333 - adds "labelClasses" to the field schema, allowing you to configure icons and other styles to labels via CSS classes.