Skip to content

[WIP] Next version #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jul 5, 2020
Merged

[WIP] Next version #12

merged 34 commits into from
Jul 5, 2020

Conversation

ktquez
Copy link
Member

@ktquez ktquez commented May 15, 2020 •
edited by shwilliam
Loading

  • Multiple destination (vue-skip-to-list)
  • Basic definition file (TypeScript)
  • Handling the link event to keep "exact" from the "vue-router"
  • Update style
  • Integration tests

ktquez and others added 24 commits May 10, 2020 13:41
@ktquez
Chore: Update scripts and deps in package.json
1ae253e
@ktquez
Chore: Update rollup config files
938d082
@ktquez
Fix: Remove tabindex prop
9734526
@ktquez
refactor: refactor VueSkipTo component
18de329
@ktquez
chore: Add options to serve dist files in package.json
1376618
@ktquez
chore: Update package name
30a6611
@ktquez
chore: Update style
9987ab7
@ktquez
chore: Handling the link event to keep "exact" from the "vue-router"
762f75e
@ktquez
chore: Add index.d.ts with basic definitions
78121c9
@ktquez
Update demo
3638a10
@ktquez
test: Update cypress tests
2d4bed8
@ktquez
chore: Update README to next version
337451d
@shwilliam
Create vue-skip-to-list component
83ccffa
@shwilliam
Create skip-link list demo site
a905292
@shwilliam
Validate skip-to list component to prop
61f2002
@shwilliam
Fix duplicate ids on multiple link-list instances
bac1df5
@shwilliam
Initial skip-to-list test
6a65166
@shwilliam
Enable passing skip-to aria-label
f20313a
@shwilliam
Fix missing object curly spacing
40c8e4d
@shwilliam
Add cypress tab plugin
dc09a6b
@shwilliam
Note data-vst usage not required
50a0683
@shwilliam
Test skip-to-list tab navigation and focus
272de10
@shwilliam
Use PascalCase for skip-to-list filename
efd8fd9
@ktquez
Merge pull request #11 from shwilliam/multiple-destinations
f33d34b 
Support multiple destinations
@ktquez ktquez marked this pull request as draft May 15, 2020 09:43
ktquez and others added 7 commits May 19, 2020 09:20
@ktquez
chore: Using skip-to as wrap to single and list anchors
0ee812f
@ktquez
Merge pull request #14 from vue-a11y/skip-to-wrapper
70853b3 
chore: Using skip-to as wrap to single and list anchors
@shwilliam
test: Update failing tests (#15)
eaad896 
- Fix `skip-to-list` demo label text
- Use tab to select skip-links
- Add test for main link label
@shwilliam
docs: Update README (#16)
4dae925 
- Add skip-link list usage to README
- Format README
@shwilliam
docs: Update README (#18)
28b8f42 
- List more classes to be used for styling
- Fix skip-list `to` demo format
@shwilliam
docs: Fix skip-list link to usage (#19)
df60abf
@shwilliam
fix: Rename skip-link list label prop to list-label (#17)
5d46c2e
@shwilliam
Copy link
Collaborator

@ktquez Happy to merge if you are 🎉

@ktquez
Copy link
Member Author

ktquez commented Jul 4, 2020

@shwilliam
I think we could launch the new version with what we have now and add other features without haste.
What do you think?

@shwilliam
Copy link
Collaborator

Totally agree! I'm happy with where we're at.

Supporting non-ID query selectors will require comprehensive testing before it makes it into a release.

@ktquez ktquez marked this pull request as ready for review July 5, 2020 12:33
@ktquez ktquez merged commit 4c52602 into master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ktquez ktquez

@shwilliam shwilliam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktquez @shwilliam