Skip to content

Update textprop.{txt,jax} #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Conversation

kuuote
Copy link
Member

@kuuote kuuote commented Nov 20, 2021

翻訳しました、よろしくお願いします。

Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見てみました

doc/textprop.jax Outdated
type テキストプロパティ名
"type" を除くすべてのフィールドは任意である。

第二引数はリストのリストで、各リストはテキストの開始と終了の位
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本的にはアラビア数字を使います。

Suggested change
第二引数はリストのリストで、各リストはテキストの開始と終了の位
第2引数はリストのリストで、各リストはテキストの開始と終了の位

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直しました。

@kuuote kuuote force-pushed the 20211120-textprop branch from 361ff34 to 3c7009b Compare December 5, 2021 07:25
Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
新規の翻訳から {hoge} の前後空白やったほうがいいかな、とも思ったけど、他の量もあるしとりえあえずOK

@tsuyoshicho tsuyoshicho requested a review from h-east December 8, 2021 13:38
@k-takata k-takata merged commit 8995db4 into vim-jp:master Dec 9, 2021
@k-takata
Copy link
Member

k-takata commented Dec 9, 2021

thx

@kuuote kuuote deleted the 20211120-textprop branch December 11, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants