Skip to content

Factorial #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2018
Merged

Factorial #59

merged 6 commits into from
Feb 10, 2018

Conversation

devNoiseConsulting
Copy link
Contributor

limited implementation of the factorial function.

First pass at creating a factorial function.
For some reason my use of the ternary operator resulting a line being
considered uncovered. Upon further reflection, the ternary wasn’t
needed and no more Uncovered lines.
@coveralls
Copy link

coveralls commented Feb 8, 2018

Pull Request Test Coverage Report for Build 91

  • 33 of 33 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 747
Relevant Lines: 747

💛 - Coveralls

moved handleErrors up to avoid ‘no-use-before define’. Coding style
changed on me.
@jhowardjr jhowardjr merged commit ce61a9b into variadicjs:develop Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants