This repository was archived by the owner on Dec 25, 2024. It is now read-only.
fix: allow use <= in script, close #68 #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
reviewed
Nov 26, 2021
| @@ -53,7 +53,7 @@ | |||
| "@vue/ref-transform": "^3.2.21", | |||
| "@vue/shared": "^3.2.21", | |||
| "defu": "^5.0.0", | |||
| "htmlparser2": "^7.2.0", | |||
| "htmlparser2": "5.0.1", | |||
There was a problem hiding this comment.
Wait what? Downgrading a dependency doesn't feel right 🤔 does it?
Maybe the issue is then in the dependency and not in this repo?
Maybe it's better to fix the problem in the root.
There was a problem hiding this comment.
@Shinigami92 When I fix the htmlparser2 bug, I'll update the dependency to latest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.