Adds uui-box examples #46
Conversation
There was a problem hiding this comment.
Hey there @krebil ! Thanks for your contribution to the package 🙌
Great work on this, I think the new page showcases the UUI Box component well. I've added a few comments for you to take a look over before we get this merged in.
src/Our.Umbraco.UiExamples.v14/src/scripts/box/box-dashboard.ts
Outdated
Show resolved
Hide resolved
src/Our.Umbraco.UiExamples.v14/src/scripts/box/box-dashboard.ts
Outdated
Show resolved
Hide resolved
src/Our.Umbraco.UiExamples.v14/src/scripts/box/box-dashboard.ts
Outdated
Show resolved
Hide resolved
| <umb-code-block language="HTML">${this.renderHeaderSlotCodeExample()}</umb-code-block> | ||
| <p> | ||
| The header slot is optional and is used to display additional content in the header of the box. | ||
| </p> |
There was a problem hiding this comment.
The header slot can also be added via the header attribute (like headline). Can we add an example of it here too please?
There was a problem hiding this comment.
Actually the only properties on uui-box is headline and headline variant, at least according to the storybook https://uui.umbraco.com/?path=/docs/uui-box--docs
There was a problem hiding this comment.
Very correct! Apologies, I was convinced that was an attribute tag as well 😊
src/Our.Umbraco.UiExamples.v14/src/scripts/box/box-dashboard.ts
Outdated
Show resolved
Hide resolved
|
@Rockerby I've updated the text and corrected typos based on your comments. I haven't been able to find any documentation on uui-box with a header property and I can't get it to work when i try myself either. So I haven't added an example for that just yet. |
|
Thanks @krebil . That looks spot on, changes checked and merged #h5yr! |
|
Hi there @krebil! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25nd, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
I've tried my hand at implementing #32
As umb-box is not a thing anymore I've added examples for uui-box instead. I'm not sure if there is enough descriptive text or not.
Let me know about any adjustments you would like me to make.
fixes #32