Skip to content

chore: Angular 16 support #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 12, 2023
Merged

Conversation

boxmein
Copy link
Contributor

@boxmein boxmein commented Jun 29, 2023

This PR makes ui-router/angular target Angular 16 in peerDependencies and during development.

Fixes #984

I've verified that the commits build and tests are passing. Where documentation was mentioning entryComponents, it was updated to remove such mentions.

@boxmein
Copy link
Contributor Author

boxmein commented Jul 3, 2023

@wawyed Now I'm stuck because it appears test:downstream cannot be completed without updating sample apps to Angular 16. And sample apps can't be updated because an Angular 16 compatible ui-router is not available.

@wawyed
Copy link
Member

wawyed commented Jul 3, 2023

We need to do the examples in order to get the build to pass

@wawyed
Copy link
Member

wawyed commented Jul 3, 2023

@wawyed Now I'm stuck because it appears test:downstream cannot be completed without updating sample apps to Angular 16. And sample apps can't be updated because an Angular 16 compatible ui-router is not available.

@boxmein create a branch with the changes to 16 for the sample angular example and then reference it in the test downstream json file. Don't worry about that as the script will use the local version when testing which is 16 compatible.

@boxmein
Copy link
Contributor Author

boxmein commented Jul 12, 2023

Right now it looks like the v16 run completed thanks to your review. What are the next steps for me?

@wawyed
Copy link
Member

wawyed commented Jul 12, 2023

I just merged the sample-app-angular can you change the test_downstream.json

@boxmein
Copy link
Contributor Author

boxmein commented Jul 12, 2023

Will do, just a moment

@wawyed wawyed merged commit 36652f1 into ui-router:master Jul 12, 2023
@lindolo25 lindolo25 mentioned this pull request Jan 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 16 support
2 participants