-
Notifications
You must be signed in to change notification settings - Fork 138
chore: Angular 16 support #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wawyed Now I'm stuck because it appears |
We need to do the examples in order to get the build to pass |
@boxmein create a branch with the changes to 16 for the sample angular example and then reference it in the test downstream json file. Don't worry about that as the script will use the local version when testing which is 16 compatible. |
Right now it looks like the v16 run completed thanks to your review. What are the next steps for me? |
I just merged the sample-app-angular can you change the test_downstream.json |
Will do, just a moment |
This PR makes ui-router/angular target Angular 16 in peerDependencies and during development.
Fixes #984
I've verified that the commits build and tests are passing. Where documentation was mentioning entryComponents, it was updated to remove such mentions.