remove ANALYZE_FOR_ENTRY_COMPONENTS #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wawyed this allows the library to be compatible with angular 16, and I've tested it, seems to work. Pls merge when you get a chance |
|
@wawyed would appreciate your timely attention on this, thankyou |
|
or are we going to wait till 16 is actually out? this will be a breaking change I guess so maybe best to wait |
removed ReflectiveInjector as is deprecated
|
Will have a look when I get some time. Thank you :) |
|
angular 16-rc is out, this is becoming more urgent. I'm already using my fork, but this is going to become a big problem soon |
|
Hi, I fixed the downstream tests in the main branch. You might need to rebase your fork. @jpike88 |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #981