Skip to content

fix(deps): update dependency eslint-config-prettier to v8 #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 21, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-prettier 7.2.0 -> 8.1.0 age adoption passing confidence

Release Notes

prettier/eslint-config-prettier

v8.1.0

Compare Source

  • Added: [flowtype/object-type-curly-spacing].
  • Added: Dummy files for the configs removed in 8.0.0. The dummy files throw an error that try to guide you how to upgrade.

v8.0.0

Compare Source

  • Changed: All configs have been merged into one!

    To upgrade, change:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier",
        "prettier/@​typescript-eslint",
        "prettier/babel",
        "prettier/flowtype",
        "prettier/react",
        "prettier/standard",
        "prettier/unicorn",
        "prettier/vue"
      ]
    }

    Into:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier"
      ]
    }

    The "prettier" config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!

    So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@​lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@​thorn0) for pointing this out!

    If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:

    {
      "extends": [
        "some-other-config-you-use",
        "plugin:prettier/recommended"
      ]
    }

    (The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main "prettier" config does not include the rules from it.)

  • Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Feb 21, 2021
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch 9 times, most recently from c67602a to 0e8a653 Compare February 27, 2021 03:01
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from 0e8a653 to 7946b3f Compare February 28, 2021 00:45
@renovate renovate bot force-pushed the renovate/eslint-config-prettier-8.x branch from 7946b3f to c5837bb Compare March 1, 2021 03:57
@JoshuaKGoldberg JoshuaKGoldberg merged commit 3e68261 into main Mar 1, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the renovate/eslint-config-prettier-8.x branch March 1, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants