Print Rule Notices #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
commented
Jul 6, 2019
egiurleo
commented
Jul 6, 2019
JoshuaKGoldberg
added
the
status: waiting for author
JoshuaKGoldberg
requested changes
Jul 6, 2019
There was a problem hiding this comment.
Mostly looks great - just commenting around getting a way around the type system complaining about your .notices being undefined.
Btw, I added some stricter ESLint rules on master, so after merging you might get some anger: #92.
Co-Authored-By: Josh Goldberg <joshuakgoldberg@outlook.com>
|
@JoshuaKGoldberg made the changes you requested! Check it out! |
egiurleo
commented
Jul 20, 2019
JoshuaKGoldberg
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR updates
reportConversionResultsto print out rule notices.