Skip to content

Added converter for jsx-no-lambda #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/converters/lintConfigs/rules/ruleConverters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ import { convertJsxCurlySpacing } from "./ruleConverters/eslint-plugin-react/jsx
import { convertJsxEqualsSpacing } from "./ruleConverters/eslint-plugin-react/jsx-equals-spacing";
import { convertJsxKey } from "./ruleConverters/eslint-plugin-react/jsx-key";
import { convertJsxNoBind } from "./ruleConverters/eslint-plugin-react/jsx-no-bind";
import { convertJsxNoLambda } from "./ruleConverters/eslint-plugin-react/jsx-no-lambda";
import { convertJsxSelfClose } from "./ruleConverters/eslint-plugin-react/jsx-self-close";
import { convertJsxWrapMultiline } from "./ruleConverters/eslint-plugin-react/jsx-wrap-multiline";

Expand Down Expand Up @@ -243,6 +244,7 @@ export const ruleConverters = new Map([
["jsx-equals-spacing", convertJsxEqualsSpacing],
["jsx-key", convertJsxKey],
["jsx-no-bind", convertJsxNoBind],
["jsx-no-lambda", convertJsxNoLambda],
["jsx-self-close", convertJsxSelfClose],
["jsx-wrap-multiline", convertJsxWrapMultiline],
["label-position", convertLabelPosition],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { RuleConverter } from "../../ruleConverter";

export const convertJsxNoLambda: RuleConverter = () => {
return {
rules: [
{
notices: ["ESLint rule 'jsx-no-bind' also checks for Function.bind"],
ruleName: "react/jsx-no-bind",
},
],
plugins: ["eslint-plugin-react"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { convertJsxNoLambda } from "../jsx-no-lambda";

describe(convertJsxNoLambda, () => {
test("conversion without arguments", () => {
const result = convertJsxNoLambda({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
notices: ["ESLint rule 'jsx-no-bind' also checks for Function.bind"],
ruleName: "react/jsx-no-bind",
},
],
plugins: ["eslint-plugin-react"],
});
});
});