Refactored converters to have names match intent #714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
This one's a big one! It's kind of a culmination of a bunch of inconsistencies that have existed for a while in the codebase:
runCli
are now calledconverters
and of typeRuleConverter
instead ofconfigConverter
; rule converters are nowRuleConverter
s accordingly.convertConfig
is nowconvertLintConfig
to match the existingconvertEditorConfig
convertComments
instead of a part ofconvert(Lint)Config
runCli
and all original config data is passed to all those convertersruleEquivalents
is passed to all root-level converters along with settings and configurations, with the intent that they add to itreporting/
logic into the individual folders for each sectionWaiting for #712 and #713 to land before making resolving merge conflicts and updating documentation.✔️