Skip to content

Further clarified config converters structure in code #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 8, 2020

PR Checklist

Overview

Before we jump into the really meaty parts of the proposed refactor, there are a couple of small improvements that would help improve ease of code comprehension on their own:

  • Standalone ConfigConverter type to use when referring to the array of functions passed to runCli that each do some kind of conversion
  • Rename convertConfig to the more precise convertLintConfig, as it's used alongside convertEditorConfig

FYI @MrCube42 if you're interested 😊

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Sep 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg merged commit 85cacbc into main Sep 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the config-converters branch September 8, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants