Skip to content

Adding the rule converter for jsx-wrap-multiline #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sakshi-gupta95
Copy link
Contributor

@sakshi-gupta95 sakshi-gupta95 commented Jul 30, 2020

PR Checklist

Overview

  1. Adding a rule converter for tslint rule jsx-wrap-multiline, Equivalent eslint rule is react/jsx-wrap-multilines (https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-wrap-multilines.md)
    react/jsx-wrap-multilines- "This rule optionally takes a second parameter in the form of an object, containing places to apply the rule. By default, all the syntax listed below will be checked except the conditions out of declaration or assignment, logical expressions and JSX attributes, but these can be explicitly disabled. Any syntax type missing in the object will follow the default behavior displayed below."
    Since tslint rule jsx-wrap-multiline does not provide any options, I have not provided the second optional argument to the eslint rule react/jsx-wrap-multiline, so it is the default.
  2. Added the required tests.

Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one needs a notice since the default behaviour is equivalent to the TSLint one. LGTM 🚀

@KingDarBoja KingDarBoja added this to the Next milestone Jul 30, 2020
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks great. Thanks @sakshi-gupta95!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9cd2b70 into typescript-eslint:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tslint-react rule: jsx-wrap-multiline
3 participants