fix: converters now uses naming-convention #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingDarBoja
added
the
status: waiting for reviewer
|
Also related to this issue at typescrip-eslint. |
JoshuaKGoldberg
requested changes
Jul 12, 2020
There was a problem hiding this comment.
Thanks for the PR, and sorry it took so long to review @KingDarBoja! It had already slipped my mind/schedule, then I took a vacation... variable-name looks good to me at first glance but the other rules need some options, I think?
JoshuaKGoldberg
added
status: waiting for author
KingDarBoja
added
status: waiting for reviewer
JoshuaKGoldberg
approved these changes
Jul 25, 2020
There was a problem hiding this comment.
Swell, I think this is about ready to ship. Very nicely done @KingDarBoja !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This should bring the latest changes from typescript-eslint (the rule removals section) as requested but not sure if I have to provide a merger for these converters @JoshuaKGoldberg