Skip to content

Add codelyzer component-class-suffix converter #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2020
Merged

Add codelyzer component-class-suffix converter #432

merged 2 commits into from
May 4, 2020

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

This is more like a example of how codelyzer rules should be placed inside their own folder so any contributor knows where find those converters.

This rule is pretty simple and examples can be found on angular-eslint/component-class-suffix test file.

The TSLint rule is pretty much the same as the ESLint one, a set of rule arguments will be the suffix to match for any class decorated with @Component.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Apr 29, 2020
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial scaffolding LGTM, thanks for setting that up! I just have a request on the options format.

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels May 3, 2020
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit dedbc02 into typescript-eslint:master May 4, 2020
@KingDarBoja KingDarBoja deleted the codelyzer-component-class-suffix-converter branch May 4, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author The PR author should address requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants