Skip to content

Removed already-installed packages from install command #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 27, 2020

PR Checklist

Overview

Separates logMissingPackages out from the multi-purpose reportConversionResults and directly calls it in convertConfig. It'll now take in the result of reading --package (normally package.json) and remove any package names contained in dependencies or devDependencies from the list of suggested packages to install.

Screenshot of the trim new CLI output

Per the notes in #416, we can't look at the extends value of an ESLint configuration file for packages that need to be installed - even though eslint-config-prettier isn't added to plugins. This PR adds in a special case for eslint-config-prettier existing in an extends. I don't know of any other ones we'll need to add to that special case... for now.

Also adds plugin: before plugin names, because that seems to be recommended by the ESLint docs.

},
devDependencies: {
...rawConfiguration.devDependencies,
...defaultPackagesConfiguration.devDependencies,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why this was added before, but it isn't doing anything... 🤷

@JoshuaKGoldberg JoshuaKGoldberg merged commit bb4dcc6 into master Apr 27, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the package-name-exclusions branch April 27, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't request installing packages already present in package.json
1 participant