Removed already-installed packages from install command #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Separates
logMissingPackages
out from the multi-purposereportConversionResults
and directly calls it inconvertConfig
. It'll now take in the result of reading--package
(normallypackage.json
) and remove any package names contained independencies
ordevDependencies
from the list of suggested packages to install.Per the notes in #416, we can't look at the
extends
value of an ESLint configuration file for packages that need to be installed - even thougheslint-config-prettier
isn't added toplugins
. This PR adds in a special case foreslint-config-prettier
existing in anextends
. I don't know of any other ones we'll need to add to that special case... for now.Also adds
plugin:
before plugin names, because that seems to be recommended by the ESLint docs.