Skip to content

Add merger for @typescript-eslint/consistent-type-assertions #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rules/mergers.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { mergeBanTypes } from "./mergers/ban-types";
import { mergeConsistentTypeAssertions } from "./mergers/consistent-type-assertions";
import { mergeIndent } from "./mergers/indent";
import { mergeNoMemberDelimiterStyle } from "./mergers/member-delimiter-style";
import { mergeNoCaller } from "./mergers/no-caller";
import { mergeNoEval } from "./mergers/no-eval";
import { mergeNoMemberDelimiterStyle } from "./mergers/member-delimiter-style";
import { mergeNoUnnecessaryTypeAssertion } from "./mergers/no-unnecessary-type-assertion";

export const mergers = new Map([
["@typescript-eslint/ban-types", mergeBanTypes],
["@typescript-eslint/consistent-type-assertions", mergeConsistentTypeAssertions],
["@typescript-eslint/indent", mergeIndent],
["@typescript-eslint/member-delimiter-style", mergeNoMemberDelimiterStyle],
["@typescript-eslint/no-unnecessary-type-assertion", mergeNoUnnecessaryTypeAssertion],
Expand Down
5 changes: 5 additions & 0 deletions src/rules/mergers/consistent-type-assertions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { RuleMerger } from "../merger";

export const mergeConsistentTypeAssertions: RuleMerger = (existingOptions, newOptions) => {
return [existingOptions?.[0] ?? newOptions?.[0]].filter(Boolean);
};
25 changes: 25 additions & 0 deletions src/rules/mergers/tests/consistent-type-assertions.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { mergeConsistentTypeAssertions } from "../consistent-type-assertions";

const option = {
assertionStyle: "never",
};

describe(mergeConsistentTypeAssertions, () => {
test("neither options existing", () => {
const result = mergeConsistentTypeAssertions(undefined, undefined);

expect(result).toEqual([]);
});

test("only existing options", () => {
const result = mergeConsistentTypeAssertions([option], undefined);

expect(result).toEqual([option]);
});

test("only new options", () => {
const result = mergeConsistentTypeAssertions(undefined, [option]);

expect(result).toEqual([option]);
});
});