update eslint rule on array-type #320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make the code more concise on array of union type
There was a problem hiding this comment.
Agh, sorry, I was incorrect when I indicated array-simple would be an ok rule setting to take in. I was mixing it up with the default one that prefers T[], which is this repository's preference.
IMO Array<T> should be a discouraged construct in the type system because:
- It's extra characters to achieve the same thing as
T[] - JavaScript usage generally discourages
Array(), with[]as the preference
|
Closing this PR as non-actionable. I know it must be annoying to have a change indicated as favorable in one PR and not in another, my sincere apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make the code more concise on array of union type
PR Checklist
status: accepting prsOverview