Skip to content

fix(reporting): "do not have an ESLint equivalent" is misleading #299 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/reporting/reportConversionResults.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ describe("reportConversionResults", () => {
);
expectEqualWrites(
logger.info.write,
"tslint-rule-one does not yet have an ESLint equivalent.",
'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-rule-one"',
);
});

Expand Down Expand Up @@ -206,8 +206,8 @@ describe("reportConversionResults", () => {
);
expectEqualWrites(
logger.info.write,
"tslint-rule-one does not yet have an ESLint equivalent.",
"tslint-rule-two does not yet have an ESLint equivalent.",
'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-rule-one"',
'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-rule-two"',
);
});

Expand Down
2 changes: 1 addition & 1 deletion src/reporting/reportConversionResults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const reportConversionResults = (
logMissingConversionTarget(
"rule",
(setting: TSLintRuleOptions) =>
`${setting.ruleName} does not yet have an ESLint equivalent.${EOL}`,
`tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "${setting.ruleName}"${EOL}`,
ruleConversionResults.missing,
dependencies.logger,
[
Expand Down
6 changes: 3 additions & 3 deletions src/reporting/reportEditorSettingConversionResults.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ describe("reportEditorSettingConversionResults", () => {
);
expectEqualWrites(
logger.info.write,
"tslint-editor-setting-one does not yet have an ESLint equivalent.",
'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-editor-setting-one"',
);
});

Expand Down Expand Up @@ -156,8 +156,8 @@ describe("reportEditorSettingConversionResults", () => {
);
expectEqualWrites(
logger.info.write,
"tslint-editor-setting-one does not yet have an ESLint equivalent.",
"tslint-editor-setting-two does not yet have an ESLint equivalent.",
'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-editor-setting-one"',
'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-editor-setting-two"',
);
});
});
3 changes: 2 additions & 1 deletion src/reporting/reportEditorSettingConversionResults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ export const reportEditorSettingConversionResults = (
if (editorSettingConversionResults.missing.length !== 0) {
const missingEditorSettingOutputMapping = (
editorSetting: Pick<EditorSetting, "editorSettingName">,
) => `${editorSetting.editorSettingName} does not yet have an ESLint equivalent.${EOL}`;
) =>
`tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "${editorSetting.editorSettingName}"${EOL}`;
logMissingConversionTarget(
"editor setting",
missingEditorSettingOutputMapping,
Expand Down