feat: add missing merger [member-delimiter-style] #254 #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshuaKGoldberg It's more like a draft like now, but I'd like to keep it as ready for review. Looking forward to get feedback from you. 😊 |
dimabory
force-pushed
the
feature/#254
branch
from
4372455 to
033f1ea
Compare
JoshuaKGoldberg
approved these changes
Dec 15, 2019
| return []; | ||
| } | ||
|
|
||
| return [merge((existingOptions || [])[0] || {}, (newOptions || [])[0] || {})]; |
There was a problem hiding this comment.
The 100% coverage requirement is failing because one part of this line isn't hit. Without looking deeply at the report, my guess is it's that you're missing a test case for old object config existing (as in, only that one, and not the new config).
JoshuaKGoldberg
added
the
status: waiting for author
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adding missing merger
@typescript-eslint/member-delimiter-style.