Skip to content

feat: add import-blacklist converter #277 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dimabory
Copy link
Contributor

PR Checklist

Overview

Adding the new converter import-blacklist --> no-restricted-imports.

@dimabory dimabory changed the title feat: add [import-blacklist] converter #277 feat: add import-blacklist converter #277 Dec 12, 2019
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable - amusing type system shenanigans. Just waiting on the one comment about the pattern format. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Dec 12, 2019
@dimabory dimabory force-pushed the feature/import-blacklist branch from 15574c8 to 3b4595a Compare December 21, 2019 20:14
@dimabory
Copy link
Contributor Author

Seems reasonable - amusing type system shenanigans. Just waiting on the one comment about the pattern format. Thanks!

ping

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Dec 31, 2019
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM. Thanks @dimabory!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 43ae0fc into typescript-eslint:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing converter: import-blacklist to no-restricted-imports
2 participants