Skip to content

Feature/convert editor settings 133 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MrCube42
Copy link
Contributor

@MrCube42 MrCube42 commented Oct 21, 2019

PR Checklist

Overview

  • Added CLI option --editor to specify an editor config path, and have it default to .vscode/settings.json
  • Renamed the method passed to runCli.ts into convertConfigs (plural)
  • Change runCli to do several conversions after each other
  • Added functionality to read VSCode editor configuration
  • Added functionality to convert VSCode editor settings from this configuration describe in issue Automatic vscode settings migration #133
"editor.codeActionsOnSave": {
    "source.fixAll.tslint": true
}

To:

"eslint.autoFixOnSave": true

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing multiple convertConfigs into runCli is really clever and I wish I'd thought of that. 😄

+1 to this general approach! Left a few comments in case they're helpful, but it sounds like you're on the right track. Thanks so much! 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 26, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Nov 1, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Nov 16, 2019
@KingDarBoja
Copy link
Collaborator

@DevInMotion Wow man, you really nailed it! 🚀

@JoshuaKGoldberg
Copy link
Member

😮 indeed, not a 'good' first issue - removed the label from the issue! 🥇 to you for sticking through this PR! I'm reviewing now.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great PR and I'm excited for all the hard work you put into it 💪. Thanks!

Left some change requests here and there, let me know what you think? 🙏

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review status: waiting for author The PR author should address requested changes and removed status: waiting for author The PR author should address requested changes status: waiting for reviewer Waiting for a maintainer to review labels Dec 8, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Dec 17, 2019
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Serious kudos for sticking through this long. Thanks so much @MrCube42! Let's get this shipped to users!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Dec 17, 2019
@JoshuaKGoldberg JoshuaKGoldberg merged commit 204edfe into typescript-eslint:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic vscode settings migration
3 participants