-
Notifications
You must be signed in to change notification settings - Fork 101
Feature/convert editor settings 133 #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/convert editor settings 133 #250
Conversation
…t (defaults to vscode)
# Conflicts: # src/cli/main.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing multiple convertConfigs
into runCli
is really clever and I wish I'd thought of that. 😄
+1 to this general approach! Left a few comments in case they're helpful, but it sounds like you're on the right track. Thanks so much! 🚀
@DevInMotion Wow man, you really nailed it! 🚀 |
😮 indeed, not a 'good' first issue - removed the label from the issue! 🥇 to you for sticking through this PR! I'm reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great PR and I'm excited for all the hard work you put into it 💪. Thanks!
Left some change requests here and there, let me know what you think? 🙏
…ult (not the original setting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. Serious kudos for sticking through this long. Thanks so much @MrCube42! Let's get this shipped to users!
PR Checklist
status: accepting prs
Overview
--editor
to specify an editor config path, and have it default to.vscode/settings.json
runCli.ts
intoconvertConfigs
(plural)runCli
to do several conversions after each otherTo: