Skip to content

add converter trailing-comma #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2019
Merged

add converter trailing-comma #242

merged 2 commits into from
Nov 3, 2019

Conversation

deerawan
Copy link
Contributor

@deerawan deerawan commented Oct 17, 2019 •
edited
Loading

PR Checklist

Overview

Add converter for trailing comma

TSLint ref
https://palantir.github.io/tslint/rules/trailing-comma/

ESLint ref
https://eslint.org/docs/rules/comma-dangle

@KingDarBoja
Copy link
Collaborator

LGTM 🚀

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 19, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core logic looks wonderful! Just requesting changes on the assorted anys.

If you don't have the time to go though and type them up, that's ok too! Just @ me and I'll merge anyway & file a followup issue.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 19, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Nov 3, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 3, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. There's a lot of logic in there and I think you did a great job automating a bunch of it. Thanks so much @deerawan!

@JoshuaKGoldberg JoshuaKGoldberg merged commit abb17d2 into typescript-eslint:master Nov 3, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: trailing-comma
3 participants
@deerawan @KingDarBoja @JoshuaKGoldberg