Skip to content

Output optimizing for unsupported rules #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Output optimizing for unsupported rules #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
272d3e9
Update reportConversionResults.test.ts
HolgerJeromin Oct 11, 2019
5a77ccf
Update reportConversionResults.ts
HolgerJeromin Oct 11, 2019
dc03a2c
updated test for single rule output
HolgerJeromin Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/reporting/reportConversionResults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ describe("reportConversionResults", () => {
// Assert
expectEqualWrites(
logger.stdout.write,
"👀 1 rule does not yet have an ESLint equivalent; defaulting to eslint-plugin-tslint. 👀",
"👀 1 rule does not yet have an ESLint equivalent (see generated log file); defaulting to eslint-plugin-tslint for these rules. 👀",
);
expectEqualWrites(
logger.info.write,
Expand Down Expand Up @@ -200,7 +200,7 @@ describe("reportConversionResults", () => {
// Assert
expectEqualWrites(
logger.stdout.write,
"👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀",
"👀 2 rules do not yet have ESLint equivalents (see generated log file); defaulting to eslint-plugin-tslint for these rules. 👀",
);
expectEqualWrites(
logger.info.write,
Expand Down
2 changes: 1 addition & 1 deletion src/reporting/reportConversionResults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const logMissingRules = (missing: TSLintRuleOptions[], logger: Logger) => {
: " rules do not yet have ESLint equivalents",
),
);
logger.stdout.write(chalk.yellow("; defaulting to eslint-plugin-tslint."));
logger.stdout.write(chalk.yellow(" (see generated log file); defaulting to eslint-plugin-tslint for these rules."));
logger.stdout.write(chalk.yellowBright(` 👀${EOL}`));

logger.info.write(
Expand Down