Skip to content

Fix member access converter #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2019
Merged

Fix member access converter #231

merged 4 commits into from
Oct 12, 2019

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Handles rule options on TSLint and provide equivalents (I think they are correct) on ESLint.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Functionality looks great! Waiting on some changes to simplify the backing code.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 10, 2019
@KingDarBoja
Copy link
Collaborator Author

💯 Functionality looks great! Waiting on some changes to simplify the backing code.

No problem, I will apply the changes this night :)

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks @KingDarBoja!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 12, 2019
@JoshuaKGoldberg JoshuaKGoldberg merged commit e408e53 into typescript-eslint:master Oct 12, 2019
@KingDarBoja KingDarBoja deleted the bugfix/explicit-member-accessibility branch October 12, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing option converters member-access / explicit-member-accessibility
2 participants