Added missing no-implicit-dependencies converter #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingDarBoja
reviewed
Oct 7, 2019
KingDarBoja
reviewed
Oct 7, 2019
|
Yeah @melbarch I think the configurations are inherently incompatible. TSLint allows you to filter out module names, while ESLint allows you to filter out files that are importing them. The resolution for tslint-to-eslint-config will be to give up including the TSLint whitelist option and add a 'notice' complaining about the difference. 🤷♂ |
JoshuaKGoldberg
added
the
status: waiting for author
JoshuaKGoldberg
approved these changes
Oct 10, 2019
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adds a missing rule converter for the no-implicit-dependencies rule.
Still not sure how to handle correctly the case when whitelist modules are given :
I saw here that all (dev dep, peer dep, opt dep ...) accepts the whitelist array, but I added them only on devDep for the moment, as they are not mapped to specific category of deps on Tslint side.
Any thoughts on this @JoshuaKGoldberg 👋