Skip to content

Added missing no-implicit-dependencies converter #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

melbarch
Copy link
Contributor

@melbarch melbarch commented Oct 7, 2019

PR Checklist

Overview

Adds a missing rule converter for the no-implicit-dependencies rule.

Still not sure how to handle correctly the case when whitelist modules are given :
I saw here that all (dev dep, peer dep, opt dep ...) accepts the whitelist array, but I added them only on devDep for the moment, as they are not mapped to specific category of deps on Tslint side.

Any thoughts on this @JoshuaKGoldberg 👋

@JoshuaKGoldberg
Copy link
Member

Yeah @melbarch I think the configurations are inherently incompatible. TSLint allows you to filter out module names, while ESLint allows you to filter out files that are importing them.

The resolution for tslint-to-eslint-config will be to give up including the TSLint whitelist option and add a 'notice' complaining about the difference. 🤷‍♂

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 10, 2019
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit f72b6b1 into typescript-eslint:master Oct 10, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing converter: no-implicit-dependencies
3 participants