Feature/converter no default export 166 #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 6, 2019 12:45
|
The end-to-end tests were broken on master. I fixed them and merged into this branch, and will make them less brittle (#216). Sorry if that was confusing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status: accepting prsOverview
Implements conversion of
no-default-exportto ESLint ruleimport/no-default-exportthat needs theimportplugin. 'no-default-export' has no configuration. Unit tests and E2E tests are included.@JoshuaKGoldberg I tried to enhance the e2e test, too. However it could not be executed
globalThiscould not be found (createTests.tsline 33). Not sure whether it really works as expected atm.