Skip to content

Added the file extension for a VS Code workspace file to .gitignore. … #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ test/*.js
~test/jest.config.js
!test/tests/**/.eslintrc*
!test/tests/**/*.log
#VS Code workspace file
*.code-workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err this and the PR title look unrelated. Could you please file a separate issue if you'd like this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the delay... I went out of town and had no service so was pretty disconnected, glad to see it got taken care of. Well, if you would like to have code-workspaces ignored I'm not opposed to resbubmitting.

2 changes: 2 additions & 0 deletions src/rules/converters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ import { convertUnifiedSignatures } from "./converters/unified-signatures";
import { convertUnnecessaryBind } from "./converters/unnecessary-bind";
import { convertUnnecessaryConstructor } from "./converters/unnecessary-constructor";
import { convertUseIsnan } from "./converters/use-isnan";
import { convertUseDefaultTypeParameter } from "./converters/use-default-type-parameter";
import { convertQuotemark } from "./converters/quotemark";
import { convertTripleEquals } from "./converters/triple-equals";

Expand Down Expand Up @@ -227,6 +228,7 @@ export const converters = new Map([
["unnecessary-bind", convertUnnecessaryBind],
["unnecessary-constructor", convertUnnecessaryConstructor],
["use-isnan", convertUseIsnan],
["use-default-type-parameter", convertUseDefaultTypeParameter],

// These converters are all for rules that need more complex option conversions.
// Some of them will likely need to have notices about changed lint behaviors...
Expand Down
17 changes: 17 additions & 0 deletions src/rules/converters/tests/use-default-type-parameter.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { convertUseDefaultTypeParameter } from "../use-default-type-parameter";

describe(convertUseDefaultTypeParameter, () => {
test("conversion without arguments", () => {
const result = convertUseDefaultTypeParameter({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "@typescript-eslint/use-default-type-parameter",
},
],
});
});
});
11 changes: 11 additions & 0 deletions src/rules/converters/use-default-type-parameter.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { RuleConverter } from "../converter";

export const convertUseDefaultTypeParameter: RuleConverter = () => {
return {
rules: [
{
ruleName: "@typescript-eslint/use-default-type-parameter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
],
};
};