Skip to content

Added ordered-imports converter #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gzuzmark
Copy link
Contributor

@gzuzmark gzuzmark commented Oct 5, 2019

PR Checklist

Overview

Added the converter and the unit tests for the ordered-imports TSLint rule.

@gzuzmark gzuzmark closed this Oct 5, 2019
@gzuzmark gzuzmark reopened this Oct 5, 2019
@gzuzmark gzuzmark changed the title initial commit Added ordered-imports converterinitial commit Oct 5, 2019
@gzuzmark gzuzmark changed the title Added ordered-imports converterinitial commit Added ordered-imports converter Oct 5, 2019
@gzuzmark gzuzmark closed this Oct 6, 2019
@gzuzmark gzuzmark reopened this Oct 6, 2019
@JoshuaKGoldberg
Copy link
Member

The end-to-end tests were broken on master. I fixed them and merged into this branch, and will make them less brittle (#216). Sorry if that was confusing!

@gzuzmark
Copy link
Contributor Author

gzuzmark commented Oct 6, 2019

The end-to-end tests were broken on master. I fixed them and merged into this branch, and will make them less brittle (#216). Sorry if that was confusing!

Np :) . Thanks for the fix/merge @JoshuaKGoldberg

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, the rule is so complex I'm sure followup issues will be filed... But for now this works 😃 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3acdba1 into typescript-eslint:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing converter: ordered-imports
2 participants