Skip to content

use of no-empty-function #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2019
Merged

use of no-empty-function #210

merged 2 commits into from
Oct 5, 2019

Conversation

afonsojramos
Copy link
Contributor

Correct use of member-ordering was already implemented.

If I understood correctly, no-empty-function now also correctly uses the correct rule naming.

PR Checklist

Overview

Changed no-empty-functions to @typescript-eslint/no-empty-function

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good catch. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8170793 into typescript-eslint:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript-specific rules should be used instead of normal eslint rules
2 participants
@afonsojramos @JoshuaKGoldberg