Skip to content

Added end-to-end tests back to CircleCI flow #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2019

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 4, 2019

PR Checklist

Overview

Instead of ts-node, which is unfortunately rather slow and is difficult to get to run in CircleCI, this makes end-to-end tests directly use node to run bin/tslint-to-eslint-config. They're faster now (yay!) but require the result of the tsc task.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 4, 2019
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 4, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 5, 2019
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8875de5 into master Oct 5, 2019
@JoshuaKGoldberg JoshuaKGoldberg deleted the end-to-end-circle branch December 12, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test:end-to-end isn't running in CircleCI
1 participant