Skip to content

Added no-async-without-await converter and unit tests #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

asponda
Copy link
Contributor

@asponda asponda commented Oct 4, 2019

PR Checklist

Overview

Added converter for TSLint rule "no-async-without-await" to ESLint rule "require-await" and unit tests

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌. Thanks @asponda!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, sorry, one change 😄.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 4, 2019
@asponda asponda force-pushed the feature/no-async-without-await-converter branch from d35d0d4 to 5678adf Compare October 5, 2019 21:39
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@JoshuaKGoldberg
Copy link
Member

I'll take a look at the end to end tests failures...

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg merged commit ecf97e7 into typescript-eslint:master Oct 6, 2019
@JoshuaKGoldberg
Copy link
Member

Ignoring end-to-end test failures as they're removed in master. 🤷‍♂

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing converter: no-async-without-await
2 participants