Skip to content

Add missing converter: newline-before-return #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Add missing converter: newline-before-return #203

merged 1 commit into from
Oct 4, 2019

Conversation

da-snap
Copy link
Contributor

@da-snap da-snap commented Oct 4, 2019

To #164

PR Checklist

Overview

Add converter for newline-before-return with suggested configuration for new padding-line-between-statements rule

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, odd that the ESLint rule docs only show examples with "error". This looks great though (the configuration is pretty cool). Thanks @da-snap!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9df14a2 into typescript-eslint:master Oct 4, 2019
@da-snap da-snap deleted the 164-newline-before-return-converter branch October 5, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: newline-before-return
2 participants
@da-snap @JoshuaKGoldberg