Skip to content

Adds no-for-in converter along with tests #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2019
Merged

Adds no-for-in converter along with tests #194

merged 2 commits into from
Oct 4, 2019

Conversation

bpallares
Copy link
Contributor

@bpallares bpallares commented Oct 3, 2019 •
edited
Loading

PR Checklist

Overview

Adds no-for-in converter

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 4, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A start!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 4, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, precisely. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit e6b3818 into typescript-eslint:master Oct 4, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: no-for-in
2 participants
@bpallares @JoshuaKGoldberg