Skip to content

fix: Do not default-import 'glob' package #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Dec 8, 2023

PR Checklist

Overview

Fixes the import. Closes #1817

As noted in the linked issue, this was caused by commit c2572c1. Maybe a rennovate config of something like:

{
  "packageRules": [
    {
      "matchUpdateTypes": ["major"],
      "enabled": false
    }
  ]
}

would have prevented this sort of error? I'm not as familiar with rennovate, but I noticed that create-typescript-app's renovate.json didn't have this configuration. I think this repository's config still has to be updated, to match that from create-typescript-app, so perhaps this question is moot.

Fixes a regression introduced in
c2572c1.
@hyperupcall hyperupcall changed the title fix: Properly import glob Do not default-import 'glob' package Dec 8, 2023
@hyperupcall hyperupcall changed the title Do not default-import 'glob' package fix: Do not default-import 'glob' package Dec 8, 2023
@JoshuaKGoldberg
Copy link
Member

Yeah renovate can be tricky. I'm surprised this wasn't caught by a test... Thanks for the quick turnaround!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 76d99f8 into typescript-eslint:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: (0 , glob_1.default) is not a function
2 participants