Merge and deduplicate rule notices #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
commented
Aug 12, 2019
src/rules/convertRules.ts
Outdated
| converted.set(changes.ruleName, { | ||
| ...existingConversion, | ||
| ruleArguments: merger( | ||
| existingConversion.ruleArguments, | ||
| newConversion.ruleArguments, | ||
| ), | ||
| notices: [...existingNotices, ...newNotices], | ||
| notices: Array.from( | ||
| new Set([...existingConversion.notices, ...newConversion.notices]), |
There was a problem hiding this comment.
Let me know if this is better than it was previously (setting a default value for notices earlier on vs in the existingNotices and newNotices variables.
There was a problem hiding this comment.
@egiurleo unfortunately no, if newNotices is undefined, this will throw an error:
Trying out in a Node CLI:
> [...undefined, ...[]]
Thrown:
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))...which seems like a missing unit test!
egiurleo
commented
Aug 12, 2019
|
@JoshuaKGoldberg take a look :) |
JoshuaKGoldberg
added
the
status: waiting for reviewer
JoshuaKGoldberg
requested changes
Aug 12, 2019
src/rules/convertRules.ts
Outdated
| converted.set(changes.ruleName, { | ||
| ...existingConversion, | ||
| ruleArguments: merger( | ||
| existingConversion.ruleArguments, | ||
| newConversion.ruleArguments, | ||
| ), | ||
| notices: [...existingNotices, ...newNotices], | ||
| notices: Array.from( | ||
| new Set([...existingConversion.notices, ...newConversion.notices]), |
There was a problem hiding this comment.
@egiurleo unfortunately no, if newNotices is undefined, this will throw an error:
Trying out in a Node CLI:
> [...undefined, ...[]]
Thrown:
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))...which seems like a missing unit test!
JoshuaKGoldberg
added
status: waiting for author
egiurleo
commented
Aug 13, 2019
JoshuaKGoldberg
approved these changes
Aug 13, 2019
|
Released in 0.2.4! ✨ |
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119