feat: add missing converters for rxjs rules
#1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
commented
Aug 29, 2021
| ["rxjs-no-subject-unsubscribe", convertNoSubjectUnubscribe], | ||
| ["rxjs-no-subject-value", convertNoSubjectValue], | ||
| ["rxjs-no-tap", convertNoTap], |
There was a problem hiding this comment.
The most correct way to convert this and no-do rules would be to convert it to ban-operators (as no-tap is deprecated) however, the ban-operators might already be declared in tslint.json and then it would give an error, I believe. Thoughts on this, @JoshuaKGoldberg?
Never mind, I guess (well, I hope so 😆) that I've figured out it by creating a merger.
JoshuaKGoldberg
approved these changes
Aug 29, 2021
| @@ -518,12 +540,23 @@ export const ruleConverters = new Map([ | |||
| ["react-tsx-curly-spacing", convertReactTsxCurlySpacing], | |||
| ["relative-url-prefix", convertRelativeUrlPrefix], | |||
| ["restrict-plus-operands", convertRestrictPlusOperands], | |||
| ["rxjs-ban-observables", convertBanObservables], | |||
| ["rxjs-ban-operators", convertBanOperators], | |||
| ["rxjs-finnish", convertFinnish], | |||
There was a problem hiding this comment.
This got me confused for a bit: there's both finnish and no-finnish as separate rules. Got it!
| ...newOptions?.[0], | ||
| }, | ||
| ]; | ||
| }; |
There was a problem hiding this comment.
Yeah 👍 this is the way to go!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
There's no specific issue for this, but as I saw that there're some missing rule converters from
rxjs-tslint-rulesI decided to propose its addition.Ref: cartant/eslint-plugin-rxjs#7