Skip to content

Added obsolete rule support to convertRules.ts #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2021
Merged

Added obsolete rule support to convertRules.ts #1148

merged 1 commit into from
Jul 6, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Sibling PR to #1063: instead of using a ruleName: "", this allows omitting a rules list altogether.

Thoughts?

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Jul 4, 2021
KingDarBoja
KingDarBoja approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 84b22ce into main Jul 6, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the obsolete-rules branch July 6, 2021 14:29
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 14, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Codelyzer (Angular) rule: prefer-inline-decorator Missing Codelyzer (Angular) rule: import-destructuring-spacing
2 participants
@JoshuaKGoldberg @KingDarBoja