Skip to content

Allowed converters to specify output rule severity #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Amusingly, the variable-name already relies on being able to output this severity. It just wasn't reflected well in the type system. Yay, structural typing!

Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so in this case the variable-name rule will always keep its current severity, right?

@JoshuaKGoldberg
Copy link
Member Author

@KingDarBoja yeah, no runtime changes here (just the weird Prettier change, guessing from an old version being re-formatted).

@JoshuaKGoldberg JoshuaKGoldberg merged commit 80ec918 into main May 11, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the output-rule-severity branch May 11, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow converters to specify a rule as being off
2 participants