Skip to content

Missing ESLint rule disable in @typescript-eslint rule converter(s) #1091

Closed
@Res42

Description

@Res42

🐛 Bug Report

  • tslint-to-eslint-config version: 2.4.2
  • ESLint version: -
  • Node version: -

Actual Behavior

This issue was created according to this comment: #1085 (comment).

There are @typescript-eslint/... rules that require to turn off their ESLint counterpart like this:

{
  // note you must disable the base rule as it can report incorrect errors
  "no-use-before-define": "off",
  "@typescript-eslint/no-use-before-define": ["error"]
}

Source: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-use-before-define.md

In the rule convertNoUseBeforeDeclare this is not disabled.

Also I think it would be good to check all @typescript-eslint rule converters for this type of bug.

Expected Behavior

@typescript-eslint rule converters that require to turn off their ESLint rule counterpart actually turn them off.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: incorrect converterRule converter with incomplete, incorrect, or invalid rule names and/or argumentsgood first issueGood for newcomers; welcome aboard!status: accepting prsPlease, send in a PR to resolve this! ✨

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions