Add rxjs no-finnish converter (#1055)

Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>

Author: KingDarBoja

src/converters/lintConfigs/rules/ruleConverters.ts

@@ -206,6 +206,7 @@ import { convertNoAsyncSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-
 import { convertNoImplicitAnyCatch } from "./ruleConverters/eslint-plugin-rxjs/no-implicit-any-catch";
 import { convertNoCreate } from "./ruleConverters/eslint-plugin-rxjs/no-create";
 import { convertNoExposedSubjects } from "./ruleConverters/eslint-plugin-rxjs/no-exposed-subjects";
+import { convertNoFinnish } from "./ruleConverters/eslint-plugin-rxjs/no-finnish";
 import { convertNoIgnoredNotifier } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-notifier";
 import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer";
 import { convertNoIgnoredSubscription } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-subscription";
@@ -428,6 +429,7 @@ export const ruleConverters = new Map([
     ["rxjs-no-implicit-any-catch", convertNoImplicitAnyCatch],
     ["rxjs-no-create", convertNoCreate],
     ["rxjs-no-exposed-subjects", convertNoExposedSubjects],
+    ["rxjs-no-finnish", convertNoFinnish],
     ["rxjs-no-ignored-notifier", convertNoIgnoredNotifier],
     ["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer],
     ["rxjs-no-ignored-subscription", convertNoIgnoredSubscription],

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-finnish.ts

@@ -0,0 +1,12 @@
+import { RuleConverter } from "../../ruleConverter";
+
+export const convertNoFinnish: RuleConverter = () => {
+    return {
+        rules: [
+            {
+                ruleName: "rxjs/no-finnish",
+            },
+        ],
+        plugins: ["eslint-plugin-rxjs"],
+    };
+};

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-finnish.test.ts

@@ -0,0 +1,18 @@
+import { convertNoFinnish } from "../no-finnish";
+
+describe(convertNoFinnish, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoFinnish({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "rxjs/no-finnish",
+                },
+            ],
+            plugins: ["eslint-plugin-rxjs"],
+        });
+    });
+});