Skip to content

Commit 482cf1d

Browse files
authored
Add rxjs no-ignored-subscription converter (#1057)
1 parent 79503f3 commit 482cf1d

File tree

3 files changed

+32
-0
lines changed

3 files changed

+32
-0
lines changed

src/converters/lintConfigs/rules/ruleConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ import { convertNoCreate } from "./ruleConverters/eslint-plugin-rxjs/no-create";
208208
import { convertNoExposedSubjects } from "./ruleConverters/eslint-plugin-rxjs/no-exposed-subjects";
209209
import { convertNoIgnoredNotifier } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-notifier";
210210
import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer";
211+
import { convertNoIgnoredSubscription } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-subscription";
211212
import { convertNoIgnoredTakeWhileValue } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value";
212213
import { convertNoIndex } from "./ruleConverters/eslint-plugin-rxjs/no-index";
213214
import { convertNoInternal } from "./ruleConverters/eslint-plugin-rxjs/no-internal";
@@ -429,6 +430,7 @@ export const ruleConverters = new Map([
429430
["rxjs-no-exposed-subjects", convertNoExposedSubjects],
430431
["rxjs-no-ignored-notifier", convertNoIgnoredNotifier],
431432
["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer],
433+
["rxjs-no-ignored-subscription", convertNoIgnoredSubscription],
432434
["rxjs-no-ignored-takewhile-value", convertNoIgnoredTakeWhileValue],
433435
["rxjs-no-index", convertNoIndex],
434436
["rxjs-no-internal", convertNoInternal],
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { RuleConverter } from "../../ruleConverter";
2+
3+
export const convertNoIgnoredSubscription: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "rxjs/no-ignored-subscription",
8+
},
9+
],
10+
plugins: ["eslint-plugin-rxjs"],
11+
};
12+
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoIgnoredSubscription } from "../no-ignored-subscription";
2+
3+
describe(convertNoIgnoredSubscription, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoIgnoredSubscription({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "rxjs/no-ignored-subscription",
13+
},
14+
],
15+
plugins: ["eslint-plugin-rxjs"],
16+
});
17+
});
18+
});

0 commit comments

Comments
 (0)