rxjs-no-unsafe-takeuntil and fix in rxjs-no-async-subscribe (#798)

* added .idea to gitignore

* fix ruleName

* fix test for no-async-subscribe

* Adding the rule, mapping it and writing the tests

* Revert "added .idea to gitignore"

                            This reverts commit 3639616

Co-authored-by: Krzysztof Brilla <brilla.krzysztof@gmail.com>
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

Author: 3 people

src/converters/lintConfigs/rules/ruleConverters.ts

@@ -199,6 +199,7 @@ import { convertNoSubjectUnubscribe } from "./ruleConverters/eslint-plugin-rxjs/
 import { convertNoSubjectValue } from "./ruleConverters/eslint-plugin-rxjs/no-subject-value";
 import { convertNoUnboundMethods } from "./ruleConverters/eslint-plugin-rxjs/no-unbound-methods";
 import { convertNoUnsafeSubjectNext } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-subject-next";
+import { convertNoUnsafeTakeUntil } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-takeuntil";
 
 /**
  * Keys TSLint rule names to their ESLint rule converters.
@@ -400,6 +401,7 @@ export const ruleConverters = new Map([
     ["rxjs-no-subject-value", convertNoSubjectValue],
     ["rxjs-no-unbound-methods", convertNoUnboundMethods],
     ["rxjs-no-unsafe-subject-next", convertNoUnsafeSubjectNext],
+    ["rxjs-no-unsafe-takeuntil", convertNoUnsafeTakeUntil],
 
     // These converters are all for rules that need more complex option conversions.
     // Some of them will likely need to have notices about changed lint behaviors...

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-async-subscribe.ts

@@ -4,7 +4,7 @@ export const convertNoAsyncSubscribe: RuleConverter = () => {
     return {
         rules: [
             {
-                ruleName: "no-async-subscribe",
+                ruleName: "rxjs/no-async-subscribe",
             },
         ],
         plugins: ["eslint-plugin-rxjs"],

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-unsafe-takeuntil.ts

@@ -0,0 +1,15 @@
+import { RuleConverter } from "../../ruleConverter";
+
+export const convertNoUnsafeTakeUntil: RuleConverter = (tslintRule) => {
+    return {
+        rules: [
+            {
+                ...(tslintRule.ruleArguments.length !== 0 && {
+                    ruleArguments: tslintRule.ruleArguments,
+                }),
+                ruleName: "rxjs/no-unsafe-takeuntil",
+            },
+        ],
+        plugins: ["eslint-plugin-rxjs"],
+    };
+};

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-async-subscribe.test.ts

@@ -9,7 +9,7 @@ describe(convertNoAsyncSubscribe, () => {
         expect(result).toEqual({
             rules: [
                 {
-                    ruleName: "no-async-subscribe",
+                    ruleName: "rxjs/no-async-subscribe",
                 },
             ],
             plugins: ["eslint-plugin-rxjs"],

src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-unsafe-takeuntil.test.ts

@@ -0,0 +1,50 @@
+import { convertNoUnsafeTakeUntil } from "../no-unsafe-takeuntil";
+
+describe(convertNoUnsafeTakeUntil, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoUnsafeTakeUntil({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "rxjs/no-unsafe-takeuntil",
+                },
+            ],
+            plugins: ["eslint-plugin-rxjs"],
+        });
+    });
+
+    test("conversion with alias argument", () => {
+        const result = convertNoUnsafeTakeUntil({
+            ruleArguments: [{ alias: ["untilDestroyed"] }],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "rxjs/no-unsafe-takeuntil",
+                    ruleArguments: [{ alias: ["untilDestroyed"] }],
+                },
+            ],
+            plugins: ["eslint-plugin-rxjs"],
+        });
+    });
+
+    test("conversion with allow argument", () => {
+        const result = convertNoUnsafeTakeUntil({
+            ruleArguments: [{ allow: ["shareReplay", "share"] }],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "rxjs/no-unsafe-takeuntil",
+                    ruleArguments: [{ allow: ["shareReplay", "share"] }],
+                },
+            ],
+            plugins: ["eslint-plugin-rxjs"],
+        });
+    });
+});