Skip to content

Commit 040fc68

Browse files
kbrillaKrzysztof Brilla
and
Krzysztof Brilla
authored
Added rxjs-no-implicit-any-catch converter (#809)
* Adding the rule, mapping it and writing the tests * added allowExplicitAny parameter conversion Co-authored-by: Krzysztof Brilla <brilla.krzysztof@gmail.com>
1 parent 594569b commit 040fc68

File tree

3 files changed

+51
-0
lines changed

3 files changed

+51
-0
lines changed

src/converters/lintConfigs/rules/ruleConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ import { convertJsxWrapMultiline } from "./ruleConverters/eslint-plugin-react/js
185185

186186
// eslint-plugin-rxjs converters
187187
import { convertNoAsyncSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-async-subscribe";
188+
import { convertNoImplicitAnyCatch } from "./ruleConverters/eslint-plugin-rxjs/no-implicit-any-catch";
188189
import { convertNoCreate } from "./ruleConverters/eslint-plugin-rxjs/no-create";
189190
import { convertNoIgnoredNotifier } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-notifier";
190191
import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer";
@@ -385,6 +386,7 @@ export const ruleConverters = new Map([
385386
["use-pipe-transform-interface", convertUsePipeTransformInterface],
386387
["variable-name", convertVariableName],
387388
["rxjs-no-async-subscribe", convertNoAsyncSubscribe],
389+
["rxjs-no-implicit-any-catch", convertNoImplicitAnyCatch],
388390
["rxjs-no-create", convertNoCreate],
389391
["rxjs-no-ignored-notifier", convertNoIgnoredNotifier],
390392
["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer],
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
import { RuleConverter } from "../../ruleConverter";
2+
3+
export const convertNoImplicitAnyCatch: RuleConverter = (tslintRule) => {
4+
return {
5+
rules: [
6+
{
7+
...(tslintRule.ruleArguments.length !== 0 && {
8+
ruleArguments: tslintRule.ruleArguments,
9+
}),
10+
ruleName: "rxjs/no-implicit-any-catch",
11+
},
12+
],
13+
plugins: ["eslint-plugin-rxjs"],
14+
};
15+
};
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
import { convertNoImplicitAnyCatch } from "../no-implicit-any-catch";
2+
3+
describe(convertNoImplicitAnyCatch, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoImplicitAnyCatch({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "rxjs/no-implicit-any-catch",
13+
},
14+
],
15+
plugins: ["eslint-plugin-rxjs"],
16+
});
17+
});
18+
19+
test("conversion with allowExplicitAny argument", () => {
20+
const result = convertNoImplicitAnyCatch({
21+
ruleArguments: [{ allowExplicitAny: true }],
22+
});
23+
24+
expect(result).toEqual({
25+
rules: [
26+
{
27+
ruleName: "rxjs/no-implicit-any-catch",
28+
ruleArguments: [{ allowExplicitAny: true }],
29+
},
30+
],
31+
plugins: ["eslint-plugin-rxjs"],
32+
});
33+
});
34+
});

0 commit comments

Comments
 (0)