Replace invalid props example #619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous example was titled "Props: Must Pass Both" with this:
Which is just weird to me, because if you really meant "must pass both", you can just do this:
...which is not very interesting and nothing to showcase as an advanced pattern. If we make it "Pass nothing or all" it gets a little bit more interesting at least!
I think the current example is actually trying to do "Pass one or the other but not both", but that's already covered in #620.