-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add setState example to Basic Prop Types #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setState example to Basic Prop Types #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggesiton but lgtm, letting @filiptammergard review
Co-authored-by: swyx <shawnthe1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Small suggestion, let's change to that and we're ready to merge!
@WillowP Last thing, can you run |
On second thought, I wonder if taking out the reference to What about:
|
Good point, yes let's go for that tweak! |
Thanks @WillowP! |
Solves #574