docs(hooks): improving useImperativeHandle example #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mateoguzmana, I think this is a great improvement. Can you run |
|
@filiptammergard maybe we should make a github action to do that for us so that we dont have to remind contributors |
Yeah I agree. I'll take a look at it! |
Closed
|
Done @filiptammergard. Thanks! |
Awesome, thanks @mateoguzmana! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled upon the current explanation for the useImperativeHandle and saw that it is pretty basic.
I found a better way to type useImperativeHandle on this Stackoverflow answer and thought we can use this one instead, which is more complete.